feat(defaultActive): set correct filter after clicking on clear#642
Open
karelhala wants to merge 1 commit intopatternfly:mainfrom
Open
feat(defaultActive): set correct filter after clicking on clear#642karelhala wants to merge 1 commit intopatternfly:mainfrom
karelhala wants to merge 1 commit intopatternfly:mainfrom
Conversation
karelhala
force-pushed
the
default-active
branch
from
511316f to
de14dae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When user clicks on clear filters the previously selected filter remains selected. This is unintuitive as we are basically clearing the whole filter section. This PR fixes it by activating first filter in the list. There's also an option to provide default filter which will be used when consumer provides it and user clears the filters.
Fixes 513